From: Étienne Deparis <etienne@depar.is>
Date: Tue, 24 Nov 2020 07:49:20 +0000 (+0100)
Subject: Avoid a crash when saving a new bookmark and elpher-bookarks-file dir is missing
X-Git-Tag: bookmarks~44^2
X-Git-Url: https://thelambdalab.xyz/gitweb/index.cgi?p=elpher.git;a=commitdiff_plain;h=f2860c3b2d20fdc456b0bf554ab846e34c4458da

Avoid a crash when saving a new bookmark and elpher-bookarks-file dir is missing

As the ‘elpher-bookmarks-file’ is customizable, one can set it to a
non-existent dir (like ‘~/.emacs.d/etc/elpher/bookrmarks’). This commit just
check that the directory part of ‘elpher-bookrmarks-file’ exists before trying
to save it.
---

diff --git a/elpher.el b/elpher.el
index 4c34f52..9ac3fc0 100644
--- a/elpher.el
+++ b/elpher.el
@@ -1618,6 +1618,9 @@ bookmark list, while URL is the url of the entry."
 (defun elpher-save-bookmarks (bookmarks)
   "Record the bookmark list BOOKMARKS to the user's bookmark file.
 Beware that this completely replaces the existing contents of the file."
+  (let ((bookmark-dir (file-name-directory elpher-bookmarks-file)))
+    (unless (file-directory-p bookmark-dir)
+      (make-directory bookmark-dir)))
   (with-temp-file elpher-bookmarks-file
     (erase-buffer)
     (insert "; Elpher bookmarks file\n\n"